Merge pull request #345 from my-game-plan/bugfix/sportvu-coordinate-s…

…ystem [StatsPerform] Fix origin and vertical orientation of SportVU
PySport · Aug 9, 2024 · 016bd3a · 016bd3a
2 parents d001eb0 + e3e0b94
commit 016bd3a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/kloppy/domain/models/common.py b/kloppy/domain/models/common.py
@@ -807,11 +807,11 @@ def provider(self) -> Provider:
 
     @property
     def origin(self) -> Origin:
-        return Origin.BOTTOM_LEFT
+        return Origin.TOP_LEFT
 
     @property
     def vertical_orientation(self) -> VerticalOrientation:
-        return VerticalOrientation.BOTTOM_TO_TOP
+        return VerticalOrientation.TOP_TO_BOTTOM
 
     @property
     def pitch_dimensions(self) -> PitchDimensions:

diff --git a/kloppy/tests/test_statsperform.py b/kloppy/tests/test_statsperform.py
@@ -270,7 +270,7 @@ def test_correct_normalized_deserialization(
         )
 
         assert tracking_dataset.records[1].ball_coordinates == Point3D(
-            x=50.615 / 105, y=1 - 35.325 / 68, z=0.0
+            x=50.615 / 105, y=35.325 / 68, z=0.0
         )
 
         # Check normalised pitch dimensions