Bugfix Release 1.2.1 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mod._CVODE_extra_output is obtained by getting data from mod.data_sim. Some symbol replacements were incorrect due to substring matching, leading to garbage code, e.g. when a symbol was a substring of a model parameter that also featured in the assignment rule.
bgoli
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed a bug in model evaluation where a model has events and assignment rules, and the assignment rule contains a variable name and a parameter where the variable is a substring match of the parameter (e.g.
E1andE1tot), this led to garbage code during string replacements.I would like to push this release asap in order to get the Biosimulators pipeline fixed, which currently breaks on this bug (see biosimulators/Biosimulators_PySCeS#6).
The other issue under Milestones for 1.2.1 has been fixed. If there are small things that should be fixed and can be done so relatively quickly, that can be discussed here.