Continous Integration Tests #129
Open
+109
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
convert to .toml setup for building on github
both are required because of cython, works locally now
|
I think some of the issues may be related to numpy 2.0. I was looking into updating pyprophet to using numpy 2.0 a month ago or so, but got busy with other work, so had to put it on hold. If you have time, would you be interested in taking this on or working on it together? |
|
We can work on it together! I will take a look at tests/test_pyprophet_score.py and tests/test_stats.py to start with |
|
I am having trouble with test_osw_4. It seems to be working fine with xgboost 1.7.3 (even with numpy 2.0) however when I upgrade to xgboost 2.0 it breaks. Any ideas? |
note tests still fail though, possibly because random seed is different?
update the tests to remove old parameters and fix tests that were failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds continuous integration tests (using the existing pyprophet tests) to pyprophet using github actions.
Note this uses pytest instead of nose because nose is no longer being maintained.
Many tests are currently failing so ideally we can address why they are failing before merging.
I also migrated setup to using a .toml file as I was having difficulties with setup.py not having a numpy requirement. Note that because cython is used a setup.py is still required.