ci: move cross compile tests to their own jobs #3887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
cross-compile-job
branch
from
9257c64
to
ee1502d
Compare
.github/workflows/ci.yml
Outdated
| @@ -488,6 +488,111 @@ jobs: | |||
| - run: python3 -m pip install --upgrade pip && pip install nox | |||
| - run: python3 -m nox -s check-feature-powerset | |||
|
|
|||
| test-cross-compilation: | |||
| needs: [fmt] | |||
| # if: ${{ contains(github.event.pull_request.labels.*.name, 'CI-build-full') || (github.event_name != 'pull_request' }} | |||
There was a problem hiding this comment.
This for testing this without attaching CI-build-full, right?
There was a problem hiding this comment.
Yep exactly, I didn't want to burn through CPUs while testing this out 😂
There was a problem hiding this comment.
Ok, the jobs are now working so I've pushed a second commit to set these if conditions up properly.
davidhewitt
force-pushed
the
cross-compile-job
branch
7 times, most recently
from
aa5a764
to
93ba995
Compare
davidhewitt
force-pushed
the
cross-compile-job
branch
from
93ba995
to
30d12ad
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slowest part of the merge queue is caused by the cross-compile tests. I believe that they also have their own chunky download which is currently not cached. PyO3/maturin#1953
By moving these into their own jobs, they should be able to be cached trivially and overall be pretty fast to run.