Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make #wrap_pyfunction return a Bound value #3808

Closed
wants to merge 1 commit into from

Make #wrap_pyfunction return a Bound value, and update module.add_met…

0e43071
Select commit
Loading
Failed to load commit list.
Closed

Make #wrap_pyfunction return a Bound value #3808

Make #wrap_pyfunction return a Bound value, and update module.add_met…
0e43071
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Feb 7, 2024 in 0s

Performance Regression: -12.82%

Summary

⚡ 5 improvements
❌ 1 regressions
✅ 73 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main snuderl:wrap_pyfunction-bound Change
not_a_list_via_downcast 242.8 ns 215 ns +12.92%
mapping_from_dict 327.8 ns 272.2 ns +20.41%
f64_from_pyobject 377.8 ns 433.3 ns -12.82%
sequence_from_list 355.6 ns 300 ns +18.52%
extract_str_downcast_fail 266.1 ns 238.3 ns +11.66%
extract_int_downcast_fail 266.1 ns 238.3 ns +11.66%