Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support &Bound<PyType> for classmethod #3744

Closed
wants to merge 2 commits into from

Conversation

davidhewitt
Copy link
Member

Build on stream this morning; there's a little bit of tidy up to do later.

This solves #3705 (comment) by introducing some helper functions in impl_/pymethods.rs

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Jan 19, 2024
Copy link

codspeed-hq bot commented Jan 19, 2024

CodSpeed Performance Report

Merging #3744 will degrade performances by 10.44%

Comparing davidhewitt:classmethod (92c8203) with main (43504cd)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 75 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main davidhewitt:classmethod Change
extract_int_downcast_fail 238.3 ns 266.1 ns -10.44%
not_a_list_via_downcast 153.9 ns 126.1 ns +22.03%
list_via_extract 303.3 ns 275.6 ns +10.08%

@LilyFoote
Copy link
Contributor

@davidhewitt Instead of doing it from scratch on #3894, I'm going to rebase this and tidy up.

@davidhewitt
Copy link
Member Author

👍 Note that a large part of this was split into #3831

@LilyFoote LilyFoote mentioned this pull request Feb 25, 2024
@davidhewitt
Copy link
Member Author

Rest is now in #3897. Thanks @LilyFoote!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants