-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify test matrix and remove merge queue #2268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maturin is shipped with ubuntu 24.04
github fixed this on their side.
Reduces the CI matrix a bit
Test only the supported range from Python 3.9 to Python 3.13. Remove unsupported pypy 3.9 (https://pypy.org/posts/2024/08/pypy-v7317-release.html#pypy-versions-and-speed-pypy-org)
We don't need to cache every docker test build
Simplify the github actions configuration some more
This is supported natively on github actions now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PR testing is a two-step process: First the regular PR tests, then the merge group tests. The test suite is flaky and test jobs take a long with limited parallelism, which means you can make a simple PR and 2h later get the notification that the PR failed due to an unrelated (and potentially temporary) error. There were several parts not passing when ran as a regular CI job. CI was failing a lot a blocking effective development. This PR radically simplifies the CI setup.
By additionally changing the required jobs, we can switch to "merge when ready" so you don't need to return to a PR to check if CI is ready.