-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: migrate to numpy v2.0.0 #596
Conversation
Allow Restriction using normalize_axis_index differently based on numpy version to enable using numpy2 whilst still using numpy1 for rtd.
@cako can you please quickly review this one, so we can make a new release that works with numpy v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, LGTM. I added a couple of changes to the testing logic to reduce the diff, and I also added a note in the documentation about dtcwt and spgl1 not working with numpy2
@mrava87 Apparently dtcwt has been archived. The new version lives in: https://github.com/xir4n/dtcwt We might want to support that fork instead. EDIT: Just saw that the fork is the one being used in PyPI. Nevermind! |
I saw this... it 'happened' as soon as I opened an Issue about numpy2 (rjw57/dtcwt#149).... now, I cannot reply anymore to this Issue thread and the fork does not have Issues (since it is a fork), so we seem to have lost all ways to communicate. I suggest that we keep this for now, it would not affect people using pylops, and consider ditching dtcwt all together in a few months if the library does not update to support numpy2. What do you think? |
I don't mind keeping it. If it becomes a pain to maintain, we can remove it in the future. |
This PR aims to allow users to use pylops with numpy>=2.0.0.
Currently we need to make the following work-arounds:
spgl1
until new release ofspgl1
libraryDTCWT
until new release ofdtcwt
libraryTorchOperator
in darwin os (currently torch does give this errorRuntimeError: Numpy is not available
)