Update that increases performance (AcousticWave2D) #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guaacoelho
changed the title
|
Hello @guaacoelho, I knew about the caching of Devito but didn't realize that it would only work if the solver is not re-created, that definitely makes sense. I am going to merge this PR. Looking forward to more features :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, my name is Gustavo Coelho. I hope this PR is useful for you.
During the creation of the Born operator, Devito uses an optimization technique that caches the result so that for subsequent executions with the same parameters, it doesn't need to recreate the operator, but simply retrieves it from the cache.
However, with a new solver being created for each shot, Pylops couldn't take advantage of this feature. This PR aims to address this issue by moving the creation of the solver outside the shots iteration loop.
Additionally, we are working on other features for Pylops and plan to make further contributions soon.