Feature: N-dimensional discrete wavelet transforms #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrava87
requested changes
Jun 16, 2024
There was a problem hiding this comment.
@solldavid this is a great additon!
I just have a few minor comments, after you address them I will be happy to merge the PR
|
PS: whilst making the changes, please also add your name at the bottom of the README file and here https://github.com/PyLops/pylops/blob/dev/docs/source/credits.rst |
|
Thanks a lot for the prompt review @mrava87! I have implemented your comments. |
|
Great, thanks a lot for this contribution :) I merge this PR now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for N-dimensional discrete wavelet transforms via a new linear operator
DWTND.This is a super minor addition building upon what is already implemented with the
DWTandDWT2Doperators. This simply generalizes those operators to N dimensions, something that we saw need for in a recent application of ours.