Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for numpy>=2.0.0 #106

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Test for numpy>=2.0.0 #106

merged 1 commit into from
Aug 26, 2024

Conversation

rohanbabbar04
Copy link
Collaborator

@rohanbabbar04 rohanbabbar04 commented Aug 25, 2024 •
edited
Loading

Closes #105

  • With the new version of PyLops released, testing for numpy >=2.0.0

@rohanbabbar04 rohanbabbar04 requested a review from mrava87 August 26, 2024 03:24
mrava87
mrava87 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@mrava87 mrava87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see we can allow numpy>2.0.0 now :) Feel free to go ahead and merge

@rohanbabbar04 rohanbabbar04 merged commit d05ebbb into main Aug 26, 2024
25 checks passed
@rohanbabbar04 rohanbabbar04 deleted the numpy2.0-test branch September 25, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrava87 mrava87 mrava87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numpy version
2 participants
@rohanbabbar04 @mrava87