Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix datatypes for macos test fails #102

Merged
merged 2 commits into from
May 26, 2024
Merged

Fix datatypes for macos test fails #102

merged 2 commits into from
May 26, 2024

Conversation

rohanbabbar04
Copy link
Collaborator

@rohanbabbar04 rohanbabbar04 commented May 26, 2024 •
edited
Loading

Closes #101

  • Change np.float128 to np.float64 in tests.
  • Change np.complex256 to np.complex128 in tests.
  • Minor change of rtol to 1e-13

@rohanbabbar04 rohanbabbar04 requested a review from mrava87 May 26, 2024 12:27
mrava87
mrava87 approved these changes May 26, 2024
View reviewed changes
Copy link
Contributor

@mrava87 mrava87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for handling this so fast. Feel free to merge.

@rohanbabbar04 rohanbabbar04 merged commit f628bd3 into main May 26, 2024
25 checks passed
@rohanbabbar04 rohanbabbar04 deleted the fix_numpy.float128 branch September 25, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrava87 mrava87 mrava87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

numpy.float128 missing
2 participants
@rohanbabbar04 @mrava87