add options for several IO operation #362
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Pre discuss in #361, this PR add options for
readbytes
andreadtext
in each class.Also it changes a behavior in
FS.open
, I found this when I was investigate if there's any other thing to be changed.It seems no extra parameters are required for
iotools.make_stream
, and the description foroptions
is arguments for the filesystem. So I guess it was misplaced and move options foropenbin
inside the function.