Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dokany 0.8.0 #241

Closed
wants to merge 2 commits into from
Closed

Dokany 0.8.0 #241

wants to merge 2 commits into from

Conversation

zommuter
Copy link

@zommuter zommuter commented Jan 8, 2016

First attempt at Dokany 0.8.0 compatibility, still WIP

@zommuter
Copy link
Author

zommuter commented Jan 8, 2016

Currently not working properly, see #236 (comment)

@zommuter zommuter changed the title Dokan 0.8.0 Dokany 0.8.0 Jan 8, 2016
@lurch
Copy link
Contributor

lurch commented Jan 8, 2016

Other thoughts:

  • I guess if Dokan is supporting arbitrary paths rather than just single drive-letters, maybe it's worth adding support for long path-names, similar to what OSFS does ? (I guess the UNC stuff here isn't relevant to Dokan though). If that's something that Dokan DLL supports, of course ;)
    (more info here )
  • I've not experimented with Dokan, but if mounting to a nested path (rather than just a non-existent drive-letter), does that path need to already exist (like mountpoints on Linux)? And if so, would it be worth checking for that first in the python-side code, or should it just let the error bubble back up from the Dokan DLL?

@zommuter
Copy link
Author

zommuter commented Jan 8, 2016

Good questions... I know dokan can pretend to be a network drive as well, but UNC shouldn't matter; concerning nested paths I'd leave that to the DLL for now. The mirror.exe shipped with dokany does unfortunately still only work with drive letters it seems. Maybe the whole drive-path issue should be moved to a separate branch and getting dokany 0.8.0 to work at all should be prioritized on first...

@zommuter
Copy link
Author

zommuter commented Jan 8, 2016

I moved the drive to path part to https://github.com/zommuter/pyfilesystem/tree/dokany-paths and #242, unfortunately that seems to have deleted our comments on that...

@lurch
Copy link
Contributor

lurch commented Aug 1, 2016

Closing in favour of #256

@lurch lurch closed this Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants