fix: "making things draggable blocks touch scrolling" #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #61 while also adding some more customizability to the
touch-action
property of draggable elements.With this PR, it is now possible to simply set
touch-action
to another value in case there's a need.This PR also adds a listener for
dragEnd
to thetouchend
event, as on mobile, when scrolling,pointerup
may never even fire.This, however, has the drawback of sometimes firing the
dragEnd
callback multiple times.I tested various other solutions to prevent this effect, including using releasePointerCapture, without any success.
The issue is not completely gone, however, as the problem of janky dragging still persists sometimes, though much less now thanks to the
touchend
event.I'll be trying multiple ways to fix it completely in the coming days. However, it's possible to almost completely fix it in userland by implementing a threshold system in the
onDrag
handler.Any feedback is very welcome!