Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to implement old raid behavior #1564

Closed
wants to merge 2 commits into from

Conversation

2stinkysocks
Copy link
Contributor

Added a config option old-raid-behavior to allow pre-1.21 raid farms to work as before, defaulting to false. Tested on ianxofour's stacking raid farm and ray's works' normal raid farm. The code was adapted from a fabric mod: https://github.com/litetex-oss/mcm-raid-restore/

@2stinkysocks
Copy link
Contributor Author

PurpurMC/PurpurDocs#102

@granny
Copy link
Member

granny commented Jul 23, 2024

The original patch ended up making a ton of unnecessary changes that weren't needed to get the old raid behavior back. After doing some testing, the change I just pushed to this PR is the bare minimum needed to get this working.

With that being said, I believe this would be better implemented as a plugin instead. This can be done by listening to the EntityDeathEvent event to remove the ominous bottle from the entity drops while also applying the corresponding bad omen effect to the player. You'd also listen to the EntityPotionEffectEvent event for the PotionEffectType of RAID_OMEN to modify it to one second.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants