refactor: remove unused code

[zakir-code]

Summary by CodeRabbit

• New Features

  • No new features introduced in this release.

• Bug Fixes

  • Removed deprecated staking transaction messages, streamlining the transaction process.

• Refactor

  • Simplified the staking module by removing unnecessary methods and references, enhancing maintainability.
  • Eliminated legacy codec registrations, reducing complexity in message handling.

• Chores

  • Updated comments regarding future removals to enhance clarity for upcoming migrations.

[coderabbitai]

Walkthrough

This pull request involves significant code removals across various files, primarily focusing on the staking module and related functionalities. Key components, such as deprecated message definitions, codec registrations, and keeper references, have been eliminated. Additionally, specific command functionalities for querying transactions have been removed, indicating a shift in the module's structure and capabilities.

Changes

File	Change Summary
app/keepers/keepers.go	Removed code that constructed allKeys in NewAppKeeper, simplifying key aggregation.
cmd/root.go	Removed rpc.QueryEventForTxCmd() command, eliminating transaction event querying functionality.
proto/fx/staking/v1/tx.proto	Deleted deprecated message definitions: MsgGrantPrivilege and MsgEditConsensusPubKey.
x/staking/module.go	Removed methods for codec registration and keeper reference, including EndBlock method.
x/staking/types/codec.go	Deleted codec registration functions for staking messages, including MsgGrantPrivilege.
x/staking/types/events.go	Removed constants related to staking events, including event types and attribute keys.
x/staking/types/keys.go	Updated AllowanceKey with a comment indicating future removal; other keys unchanged.

Possibly related PRs

• feat(gov): update store key value #563: The changes in app/keepers/keepers.go involve the NewAppKeeper function, which is directly related to modifications made in the same file in this PR, where a new function initGovStoreSpace is introduced.
• chore: remove unused expected interface #678: The removal of the DistributionKeeper interface in x/crosschain/types/expected_keepers.go suggests a broader refactor of keeper interfaces, which may relate to changes in app/keepers/keepers.go where the keeper structure is also being modified.

Suggested labels

automerge

Poem

🐇 In the code, we hop and play,
With changes brightening the day.
Old messages now take their leave,
In cleaner paths, we do believe.
With every line, we make it right,
A new dawn breaks, oh what a sight! 🌼

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bf67f2d and 6966b2d.

Files ignored due to path filters (1)

• x/staking/types/tx.pb.go is excluded by !**/*.pb.go

Files selected for processing (7)

• app/keepers/keepers.go (0 hunks)
• cmd/root.go (0 hunks)
• proto/fx/staking/v1/tx.proto (0 hunks)
• x/staking/module.go (0 hunks)
• x/staking/types/codec.go (0 hunks)
• x/staking/types/events.go (0 hunks)
• x/staking/types/keys.go (1 hunks)

Files not reviewed due to no reviewable changes (6)

• app/keepers/keepers.go
• cmd/root.go
• proto/fx/staking/v1/tx.proto
• x/staking/module.go
• x/staking/types/codec.go
• x/staking/types/events.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.