-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace v6.0 binary with v6.1 #643
Conversation
WalkthroughThe recent updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- cosmovisor.Dockerfile (2 hunks)
- cosmovisor_lite.Dockerfile (2 hunks)
Additional comments not posted (4)
cosmovisor.Dockerfile (2)
13-13
: Verify the new base image integration.The new base image
ghcr.io/functionx/fx-core:6.1.0
is correctly introduced asfxv6
. Ensure that this image is available and correctly configured for your use case.
34-34
: Ensure correct binary path forfxcored
.The COPY command for
fxcored
fromfxv6
to/root/.fxcore/cosmovisor/upgrades/v6.0.x/bin/
is correctly formatted. Verify that this path aligns with your upgrade strategy and that the binary is correctly placed.Verification successful
Binary path for
fxcored
is correctly aligned with the upgrade strategy.The
COPY
command incosmovisor.Dockerfile
correctly placesfxcored
in/root/.fxcore/cosmovisor/upgrades/v6.0.x/bin/
, and this path is consistently referenced in the repository. No issues found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct placement of the `fxcored` binary. # Test: Check if the binary is correctly placed in the Docker image. docker run --rm ghcr.io/functionx/fx-core:6.1.0 ls /usr/bin/fxcoredLength of output: 143
Script:
#!/bin/bash # Find the Dockerfile to verify the `COPY` command for `fxcored` fd 'cosmovisor.Dockerfile' --exec cat {} # Search for any references to the upgrade path in the repository rg '/root/.fxcore/cosmovisor/upgrades/v6.0.x/bin/fxcored'Length of output: 1792
cosmovisor_lite.Dockerfile (2)
34-34
: Ensure correct binary path forfxcored
.The COPY command for
fxcored
fromfxv6
to/root/.fxcore/cosmovisor/upgrades/v6.0.x/bin/
is correctly formatted. Verify that this path aligns with your upgrade strategy and that the binary is correctly placed.Verification successful
Binary path for
fxcored
is correctly used.The path
/root/.fxcore/cosmovisor/upgrades/v6.0.x/bin/fxcored
is consistently used in the Dockerfiles, aligning with the upgrade strategy. This confirms that the binary is correctly placed according to the intended design. No further action is needed.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct placement of the `fxcored` binary. # Test: Check if the binary is correctly placed in the Docker image. docker run --rm ghcr.io/functionx/fx-core:6.1.0 ls /usr/bin/fxcoredLength of output: 143
Script:
#!/bin/bash # Search for occurrences of the binary path in the codebase to verify its usage. rg '/root/.fxcore/cosmovisor/upgrades/v6.0.x/bin/fxcored' --context 5Length of output: 2023
13-13
: Verify the new base image integration.The new base image
ghcr.io/functionx/fx-core:6.1.0
is correctly introduced asfxv6
. Ensure that this image is available and correctly configured for your use case.
mg |
Summary by CodeRabbit
fxcored
binary in bothcosmovisor
andcosmovisor_lite
.fxcored
binary.