test: fix test with nightly

[zakir-code]

Summary by CodeRabbit

• Performance Improvements

  • Enhanced test execution performance by enabling parallel processing with multi-core utilization for integration and cross-chain tests.

• Refactor

  • Streamlined timeout handling in the test suite to ensure consistent usage of timeout values across various network operations, improving readability and maintainability.

[coderabbitai]

Walkthrough

The changes enhance the performance and maintainability of the testing framework. The Makefile update allows tests to utilize multiple CPU cores, improving execution speed. In tests/suite.go, timeout handling is refactored for better encapsulation, ensuring consistent reference to timeout values across the test suite. These modifications streamline test execution and configuration management, leading to faster and more reliable tests while keeping the overall functionality intact.

Changes

Files	Change Summary
Makefile, tests/suite.go	- Added -cpu 4 flag to go test commands in Makefile for improved parallel test execution. - Refactored timeout handling in SetupSuite to use suite.timeoutCommit for consistency and readability. - Updated BroadcastTx function to adjust transaction mining wait time using the new timeout value.

Poem

🐇 In a world where tests do race,
With CPU cores, we find our pace!
Timeout values, now neatly aligned,
Improving our code, oh how refined!
Hops of joy for each test case,
A speedy path, let’s quicken our chase! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f90e62c and be2bacf.

Files selected for processing (2)

• Makefile (1 hunks)
• tests/suite.go (5 hunks)

Additional comments not posted (4)

Makefile (1)

178-179: LGTM! Verify the usage of the -cpu flag.

The addition of the -cpu 4 flag to the go test commands will improve test performance by allowing parallel execution. Ensure that the tests are compatible with parallel execution and do not introduce race conditions.

tests/suite.go (3)

95-95: LGTM! Verify the usage of the timeoutCommit field.

The votingPeriod calculation now uses suite.timeoutCommit, ensuring consistent reference to the timeout value.

---

277-277: LGTM! Verify the usage of the timeoutCommit field.

The wait time for transaction mining is adjusted to use 200 * suite.timeoutCommit and 10 * suite.timeoutCommit, promoting consistency in timeout handling.

---

81-83: LGTM! Verify the usage of the timeoutCommit field.

The refactoring of timeoutCommit to a field of the TestSuite struct enhances encapsulation and consistency in timeout handling.

Verification successful

---

Verified: The usage of the timeoutCommit field in the TestSuite class is consistent and correct.

• tests/suite.go: The timeoutCommit field is used appropriately for setting timeouts and calculating durations.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of the `timeoutCommit` field in the `TestSuite` class.

# Test: Search for the usage of the `timeoutCommit` field. Expect: Consistent usage throughout the file.
rg --type go -A 2 $'timeoutCommit'

Length of output: 1000