refactor: move crosschain timeout logic from endBlock to tryAttestion (…

…#272)

Co-authored-by: fx0x55 <[email protected]>

x/crosschain/keeper/abci.go

@@ -13,8 +13,6 @@ import (
 func (k Keeper) EndBlocker(ctx sdk.Context) {
 	signedWindow := k.GetSignedWindow(ctx)
 	k.slashing(ctx, signedWindow)
-	k.cleanupTimedOutBatches(ctx)
-	k.cleanupTimeOutRefund(ctx)
 	k.createOracleSetRequest(ctx)
 	k.pruneOracleSet(ctx, signedWindow)
 }

x/crosschain/keeper/abci_test.go

@@ -638,13 +638,15 @@ func (suite *KeeperTestSuite) TestCleanUpRefundTimeout() {
 		BridgerAddress: suite.bridgerAddrs[0].String(),
 		ChainName:      suite.chainName,
 	}
+	suite.ctx = suite.ctx.WithEventManager(sdk.NewEventManager())
 	_, err = suite.MsgServer().BridgeCallClaim(sdk.WrapSDKContext(suite.ctx), bridgeCallClaim)
 	suite.NoError(err)
 
 	recordExist := false
 	for _, event := range suite.ctx.EventManager().Events() {
 		if event.Type == types.EventTypeBridgeCallRefund {
 			recordExist = true
+			break
 		}
 	}
 	suite.True(recordExist)
@@ -669,8 +671,6 @@ func (suite *KeeperTestSuite) TestCleanUpRefundTimeout() {
 	_, err = suite.MsgServer().SendToFxClaim(sdk.WrapSDKContext(suite.ctx), sendToFxClaim)
 	require.NoError(suite.T(), err)
 
-	suite.Commit()
-
 	_, err = suite.QueryClient().RefundRecordByNonce(sdk.WrapSDKContext(suite.ctx), &types.QueryRefundRecordByNonceRequest{ChainName: suite.chainName, EventNonce: 2})
 	suite.ErrorIs(err, status.Error(codes.NotFound, "refund record"), suite.chainName)
 }

x/crosschain/keeper/attestation.go

@@ -103,6 +103,10 @@ func (k Keeper) TryAttestation(ctx sdk.Context, att *types.Attestation, claim ty
 		}
 		ctx.EventManager().EmitEvent(event)
 
+		// execute the timeout logic
+		k.cleanupTimedOutBatches(ctx)
+		k.cleanupTimeOutRefund(ctx)
+
 		k.pruneAttestations(ctx)
 		break
 	}