Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle of small fixes #612

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

mustache0110
Copy link
Contributor

@mustache0110 mustache0110 commented Sep 8, 2024

Started playing/testing from the beginning and noticed some things that could be fixed. Just a bunch of small issues, but i tried to separate them for easier review.

Built for testing: https://mustache0110.github.io/SynergismNotOfficial/

Overview of each commit:

  • 4975f2e
    Simply removed unnecessary things causing front-of-line semicolons. No logic changes. Preferred < > type assertions over as when needed for property access.
    • 204618a
      (Optional) Followup switching more as to < > on things that didn't trip up ASI. Saves a few characters, < > type assertions stand out better to me. It's a shame they conflict with JSX.
  • 2cfd341
    Added class tag so buildings line up while images are loading. Buy code attempted to buy [2, 11, 101, 1001, ...] instead of [1, 10, 100, 1000, ...] due to the addition of smallestInc.. Turned off purchase available coloring when auto-buyer is active.
  • b358bbf
    Most reported text error. Platonic Cubes to Quarks fix
  • 41764a1
    Tried to make rune descriptions more consistent. SI/IA rune lines are the shortest we have; I unabbreviated, pulling from their "runes":"names" if translated. Changed all bonus to be comma separated. Removed a stray '
  • ec558f7
    Added a missing challenge bonus text. Change tabBorder color with key navigation.
  • 003b3d5
    Remembers 10k 100k on buyers instead of resetting to 1.
  • 278ebed
    Rune tab missing initial color, Corruption tab mismatched to Singularity tab.
    • 2a65213
      Changed Corruption subTab to use background color as indicator, border is harder to tell which is active? Closer to the learned cues from other tabs.
    • 3f87688
      Subtabs have no memory per Tab, they're saved/loaded by looking at Button.backgroundColor in the DOM. They're also reset to 0 on page load, file load, and on singularity. Moved out of the player save and into Globals.
    • 993e001
      Replaced corruptionShowStats for same reasons above, moving the logic into Globals.currentSubTab.
  • e1a60dc
    Some Sing upgrades get a +0.2, +0.25 or +0.5 daily code bonus, show those non-integer numbers if needed.
  • d4321fb
    Hotkey Tab using wrong subTab index to update screen. Switched close tab hotkey to use event.key instead of event.code. The other hotkeys use event.key, and you can get some weird behavior by mixing. Also, in the Dvorak layout, CTRL-X(code) is CTRL-Q(key) which tries to quit on me.
  • d1b43f2
    Local lint passed, but GH insists.
  • 0f2696b
    • Removes extra yellow 0 after the blue total Octeract Multiplier number.
    • Starts ambrosia generation when navigating to the tab via keyboard navigation (was only tab click previously).
    • Fixes bug where you could enter the hidden reincarnation challenge by pressing 6 before your first Reincarnation. Doing so leaves you unable to buy researches and forces you to repeat the first Reincarnation with no buffs. This happens when the offline progress awards very small amounts of reincarnationCount based on your offline time and fastest reincarnate ever (999999999999 seconds), leaving you with a very small but nonzero value for your Count.
  • bcbdd5c
    • Refinements to previous bundle changes. Quarks is wider than Cubes and causes wrapping on 6 digit numbers prior to switch to scientific notation.
    • Makes the "Last enabled hotkey:" show actual key presses, partial modifier presses, and not display doubled modifiers.
  • 2c35675
    • Removes 3 days of banked offerings received on a fresh save when you first prestige.
    • Also sets the start time for each layer to the start time of the fresh save. For more pedantic accurate timing. It also has the side-effect of making the acceleration boost phase a little longer, rather than feeling like you just skip past it.

@mustache0110 mustache0110 changed the title Bundle Bundle of small fixes Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant