-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle of small fixes #612
Open
mustache0110
wants to merge
17
commits into
Pseudo-Corp:master
Choose a base branch
from
mustache0110:bundle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove player.{subtabNumber,tabNumber}, instead using Globals.current{Tab,SubTab}. Subtab state is reset every tab change and exist for UpdateHTML.ts use
Remove player.corruptionShowStats and use Global.currentSubTab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started playing/testing from the beginning and noticed some things that could be fixed. Just a bunch of small issues, but i tried to separate them for easier review.
Built for testing: https://mustache0110.github.io/SynergismNotOfficial/
Overview of each commit:
Simply removed unnecessary things causing front-of-line semicolons. No logic changes. Preferred < > type assertions over as when needed for property access.
(Optional) Followup switching more as to < > on things that didn't trip up ASI. Saves a few characters, < > type assertions stand out better to me. It's a shame they conflict with JSX.
Added class tag so buildings line up while images are loading. Buy code attempted to buy [2, 11, 101, 1001, ...] instead of [1, 10, 100, 1000, ...] due to the addition of smallestInc.. Turned off purchase available coloring when auto-buyer is active.
Most reported text error. Platonic Cubes to Quarks fix
Tried to make rune descriptions more consistent. SI/IA rune lines are the shortest we have; I unabbreviated, pulling from their "runes":"names" if translated. Changed all bonus to be comma separated. Removed a stray '
Added a missing challenge bonus text. Change tabBorder color with key navigation.
Remembers 10k 100k on buyers instead of resetting to 1.
Rune tab missing initial color, Corruption tab mismatched to Singularity tab.
Changed Corruption subTab to use background color as indicator, border is harder to tell which is active? Closer to the learned cues from other tabs.
Subtabs have no memory per Tab, they're saved/loaded by looking at Button.backgroundColor in the DOM. They're also reset to 0 on page load, file load, and on singularity. Moved out of the player save and into Globals.
Replaced corruptionShowStats for same reasons above, moving the logic into Globals.currentSubTab.
Some Sing upgrades get a +0.2, +0.25 or +0.5 daily code bonus, show those non-integer numbers if needed.
Hotkey Tab using wrong subTab index to update screen. Switched close tab hotkey to use event.key instead of event.code. The other hotkeys use event.key, and you can get some weird behavior by mixing. Also, in the Dvorak layout, CTRL-X(code) is CTRL-Q(key) which tries to quit on me.
Local lint passed, but GH insists.
pedanticaccurate timing. It also has the side-effect of making the acceleration boost phase a little longer, rather than feeling like you just skip past it.