Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored CalcECC function to simplify calls. #440

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Yayformee
Copy link
Contributor

Changed the parameters from (type, #completions) to (index).
This can be done since both the type and the #completions strictly depend on the challenge index.

Changed the parameters from (type, #completions) to (index).
This can be done since both the type and the #completions strictly depend on the challenge index.
Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We're currently working on other things so this PR will probably be delayed a little longer.

Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry but I've changed my mind. It does simplify it, but I think it's too much if that makes sense. I like that it has to be explicitly called with a type; I'd rather keep it that way. Of course a change where moving player.challengecompletions[index]s could be moved to CalcECC in a way that still simplifies the code while still making the function explicit.

@Yayformee
Copy link
Contributor Author

Completed changes as requested.

@Yayformee Yayformee requested a review from KhafraDev June 11, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants