Skip to content

Commit

Permalink
CI: fix/update playwright browser installation
Browse files Browse the repository at this point in the history
  • Loading branch information
larabr committed Nov 28, 2023
1 parent df5e88a commit a9477b5
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 30 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ jobs:
- run: npm run test-type-definitions

- name: Install Chrome
run: npx playwright install-deps chromium
run: npx playwright install --with-deps chromium

- name: Install Firefox
run: npx playwright install-deps firefox
run: npx playwright install --with-deps firefox

- name: Install Webkit
run: npx playwright install-deps webkit
run: npx playwright install --with-deps webkit

- name: Run tests
run: npm test
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ const sessionKey = await decryptSessionKey({

## Testing
Headless Chrome (or Chromium), Firefox and Webkit are used for the tests.
To install any missing browsers automatically, you can run `npx playwright install-deps <chromium|firefox|webkit>`. Alternatively, you can install them manually as you normally would on your platform.
To install any missing browsers automatically, you can run `npx playwright install --with-deps <chromium|firefox|webkit>`. Alternatively, you can install them manually as you normally would on your platform.
If you'd like to test on a subset of browsers, use e.g. `npm test -- --browsers ChromeHeadless,FirefoxHeadless`.


51 changes: 26 additions & 25 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"karma-webkit-launcher": "^1.0.2",
"karma-webpack": "^5.0.0",
"mocha": "^9.2.0",
"playwright": "^1.25.0",
"playwright": "^1.40.0",
"ts-loader": "^9.4.1",
"typescript": "^4.9.5",
"webpack": "^5.66.0",
Expand Down

0 comments on commit a9477b5

Please sign in to comment.