Merge pull request #481 from Proteobench/type_issues

🐛 filling object column with boolean values
Proteobench · Dec 11, 2024 · e31ff49 · e31ff49
2 parents cbebe0a + 3584576
commit e31ff49
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/webinterface/pages/base_pages/quant.py b/webinterface/pages/base_pages/quant.py
@@ -289,21 +289,19 @@ def filter_data_submitted_slider(self) -> None:
 
     def set_highlight_column_in_submitted_data(self) -> None:
         """Initializes the highlight column in the data points."""
+        df = st.session_state[self.variables_quant.all_datapoints_submitted]
         if (
             self.variables_quant.highlight_list_submitted not in st.session_state.keys()
-            and "Highlight" not in st.session_state[self.variables_quant.all_datapoints_submitted].columns
+            and "Highlight" not in df.columns
         ):
-            st.session_state[self.variables_quant.all_datapoints_submitted].insert(
-                0, "Highlight", [False] * len(st.session_state[self.variables_quant.all_datapoints_submitted].index)
-            )
-        elif "Highlight" not in st.session_state[self.variables_quant.all_datapoints_submitted].columns:
-            st.session_state[self.variables_quant.all_datapoints_submitted].insert(
-                0, "Highlight", st.session_state[self.variables_quant.highlight_list_submitted]
-            )
-        elif "Highlight" in st.session_state[self.variables_quant.all_datapoints_submitted].columns:
-            st.session_state[self.variables_quant.all_datapoints_submitted]["Highlight"] = st.session_state[
-                self.variables_quant.all_datapoints_submitted
-            ]["Highlight"].fillna(False)
+            df.insert(0, "Highlight", [False] * len(df.index))
+        elif "Highlight" not in df.columns:
+            df.insert(0, "Highlight", st.session_state[self.variables_quant.highlight_list_submitted])
+        elif "Highlight" in df.columns:
+            # Not sure how 'Highlight' column became object dtype
+            df["Highlight"] = df["Highlight"].astype(bool).fillna(False)
+        # only needed for last elif, but to be sure apply always:
+        st.session_state[self.variables_quant.all_datapoints_submitted] = df
 
     def generate_main_slider(self) -> None:
         """Creates a slider input."""
@@ -423,6 +421,7 @@ def save_intermediate_submission_data(self) -> None:
         self.user_input["input_csv"].getbuffer()
 
         if "storage" in st.secrets.keys():
+            logger.info("Save intermediate raw")
             self.ionmodule.write_intermediate_raw(
                 dir=st.secrets["storage"]["dir"],
                 ident=_id,