Skip to content

Commit

Permalink
Lock mglaman/drupal-check on <=1.2.1
Browse files Browse the repository at this point in the history
Because newer versions produces malformed JSON output and run PHPStan on level 2 that causes extra overhead on downstream projects without PHPStan's baseline feature available.

See: mglaman/drupal-check#274 and https://mglaman.dev/blog/drupal-check-140-enforcing-phpstan-level-2

Issue-Link: https://project.pronovix.net/issues/17233
(cherry picked from commit 20927cff7eb356ec6b81f51838fbd7078459c027)
Change-Id: I75d4faf6ad7e1e1c0c66288ace02677b7faf127b
  • Loading branch information
mxr576 authored and lekob committed May 2, 2022
1 parent ba2ee4e commit 4fb74ae
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
],
"_comment": [
"composer/composer is not a dev requirement because this library depends on code from that",
"drupal/core-dev is here but the dependent package also must also require it otherwise it could happen that incorrect/unmatching versions gets installed with drupal/core and drupal/core-recommended"
"mglaman/drupal-check is locked on <=1.2.1 because newer versions produces malformed JSON output and run PHPStan on level 2. See: https://github.com/mglaman/drupal-check/issues/274 and https://mglaman.dev/blog/drupal-check-140-enforcing-phpstan-level-2"
],
"require": {
"php": "^7.4.0",
Expand All @@ -28,7 +28,7 @@
"ergebnis/composer-normalize": "^2.13.0",
"friendsoftwig/twigcs": "^3.1",
"instaclick/php-webdriver": "^1.4.5",
"mglaman/drupal-check": "^1.2",
"mglaman/drupal-check": "<=1.2.1",
"phpspec/prophecy-phpunit": "^2",
"phpstan/phpstan": "^1.2",
"pronovix/composer-logger": "^3.0",
Expand Down

0 comments on commit 4fb74ae

Please sign in to comment.