Fix PHP notice: Undefined index: samples (#128)

* Fix PHP notice: Undefined index: samples collectHistograms() in the storage adapters does not define ['samples'] as the default array keys and as such a notice is thrown when the MetricFamilySamples::__construct($data) is called when no samples are available. * added space --------- Co-authored-by: Lukas Kämmerling <[email protected]>
PromPHP · Nov 6, 2023 · 735ace7 · 735ace7
1 parent 6f306e9
commit 735ace7
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/Prometheus/MetricFamilySamples.php b/src/Prometheus/MetricFamilySamples.php
@@ -40,8 +40,10 @@ public function __construct(array $data)
         $this->type = $data['type'];
         $this->help = $data['help'];
         $this->labelNames = $data['labelNames'];
-        foreach ($data['samples'] as $sampleData) {
-            $this->samples[] = new Sample($sampleData);
+        if (isset($data['samples'])) {
+            foreach ($data['samples'] as $sampleData) {
+                $this->samples[] = new Sample($sampleData);
+            }
         }
     }