Correctly handle empty username for Redis/RedisNg AUTH (#170)

Signed-off-by: Reda <[email protected]>
PromPHP · Dec 10, 2024 · 3f8e4ff · 3f8e4ff
1 parent abe6bbb
commit 3f8e4ff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Prometheus/Storage/Redis.php b/src/Prometheus/Storage/Redis.php
@@ -198,7 +198,7 @@ private function ensureOpenConnection(): void
         $this->connectToServer();
         $authParams = [];
 
-        if (isset($this->options['user'])) {
+        if (isset($this->options['user']) && $this->options['user'] !== '') {
             $authParams[] = $this->options['user'];
         }
 

diff --git a/src/Prometheus/Storage/RedisNg.php b/src/Prometheus/Storage/RedisNg.php
@@ -198,7 +198,7 @@ private function ensureOpenConnection(): void
         $this->connectToServer();
         $authParams = [];
 
-        if (isset($this->options['user'])) {
+        if (isset($this->options['user']) && $this->options['user'] !== '') {
             $authParams[] = $this->options['user'];
         }