Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 [神器737] 百分一剣の修正 #202

Closed
wants to merge 1 commit into from
Closed

Conversation

Lapis-LJA
Copy link
Contributor

これでエラーは出なくなったはず

Copy link
Member

@haiiro2gou haiiro2gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これってなんでエラー吐くんだっけ
場合によってはcheck_conditionで弾いたほうが丸そう

@Lapis-LJA
Copy link
Contributor Author

エラー吐く理由はバニラ殴りで敵が死んだ際に最大体力を取得できないから
確かにcheck_conditionで弾くのは一理あるかもしれないけど、今はもうバニラ殴りで死ぬことはないから問題ない気はする

@haiiro2gou
Copy link
Member

現状でまだバグってるようならマージするという形で…

@haiiro2gou haiiro2gou changed the title [神器737] 百分一剣の修正 🩹 [神器737] 百分一剣の修正 Nov 14, 2024
@Lapis-LJA
Copy link
Contributor Author

DamageLibをDamageAPIに変更するPRってことでいいかもしれん(

@Lapis-LJA
Copy link
Contributor Author

多分バグはないってことで

@Lapis-LJA Lapis-LJA closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants