3129 Gallery Sidebar Not Visible

[cyrusnaficy]

Resolves #3129

When there were less than the full # of gallery view entries, the sidebar was not fully visible. I changed the height of the container to fix this. I'm still keeping this as a draft for the moment though because the sidebar is messed up upon attempting to scroll below the margins of the screen.

Before/After screenshots (if applicable)

Before

##After

TESTING INSTRUCTIONS

1. Go onto the gallery view option in a city with little tasks (ex. New Taipei)
2. Select middle severity & obstacle blocking & fire hydrants, then scroll to the second page.
3. note -> Upon scrolling the sidebar still bugs, working on a fix.

Things to check before submitting the PR

• I've written a descriptive PR title.
• I've included before/after screenshots above.

[cyrusnaficy]

Fixed the scrolling issue, ready for review now.

[misaugstad]

This is great! Though how hard would it be to keep it so that the sidebar continues to be sticky up until the point where the bottom of the sidebar reaches the bottom of the page of cards?

[cyrusnaficy]

This is great! Though how hard would it be to keep it so that the sidebar continues to be sticky up until the point where the bottom of the sidebar reaches the bottom of the page of cards?

@misaugstad Fixed this so its sticky only if there are less than 6 results on the page. Will make it move all the way down when it can.

[misaugstad]

This is great! Though how hard would it be to keep it so that the sidebar continues to be sticky up until the point where the bottom of the sidebar reaches the bottom of the page of cards? Screenshot from 2024-08-28 12-16-43

@misaugstad Fixed this so its sticky only if there are less than 6 results on the page. Will make it move all the way down when it can.

I don't think you quite understood what I meant here. Ultimately what we want is for the sidebar to move with the page as you scroll until the bottom of the sidebar hits the top of the footer. This way, the sidebar is never hidden under the footer, and you see as much of the sidebar as possible at all times.

With your most recent change, the sidebar can be hidden by the footer again (this is what I'm seeing with only one row of cards):

And the footer isn't getting all the way to the top of the footer before being hidden by the navbar:

[cyrusnaficy]

This is great! Though how hard would it be to keep it so that the sidebar continues to be sticky up until the point where the bottom of the sidebar reaches the bottom of the page of cards? Screenshot from 2024-08-28 12-16-43

@misaugstad Fixed this so its sticky only if there are less than 6 results on the page. Will make it move all the way down when it can.

I don't think you quite understood what I meant here. Ultimately what we want is for the sidebar to move with the page as you scroll until the bottom of the sidebar hits the top of the footer. This way, the sidebar is never hidden under the footer, and you see as much of the sidebar as possible at all times.

With your most recent change, the sidebar can be hidden by the footer again (this is what I'm seeing with only one row of cards):

And the footer isn't getting all the way to the top of the footer before being hidden by the navbar:

Sounds good, sorry for the misunderstanding. I'll work on a new version with these changes ASAP. I didn't see those issues while testing on my end so will try and reproduce too to see whats going on.