Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery sidebar not fully visible if there isn't a full page of cards #3129

Open
misaugstad opened this issue Feb 9, 2023 · 4 comments · May be fixed by #3615
Open

Gallery sidebar not fully visible if there isn't a full page of cards #3129

misaugstad opened this issue Feb 9, 2023 · 4 comments · May be fixed by #3615
Assignees
@cyrusnaficy
Labels
Bug Gallery

Comments

@misaugstad
Copy link
Member

Brief description of problem/feature

When there isn't a full page of cards to show, the height of the page is decreased to the point where some or all of the sidebar filters can be hidden. Issue #2716 is a specific instance of this when we show no cards at all. Here are a few screenshots that demonstrate the problem (some courtesy of @devonsnyder):

Screenshot from 2023-02-09 10-47-20

Screenshot from 2023-02-09 10-47-09

image (2)

image (1)

image
@jonfroehlich
Copy link
Member

Easiest fix might be a min-height on the main content div.

@misaugstad
Copy link
Member Author

Looks like I actually ended up fixing #2716 as part of PR #3118 but there are definitely still issues here!

Note that when I get to the last page here, some of the bottom of the sidebar is cut off...
Screenshot from 2023-02-24 12-56-48

Then I can scroll down to reveal it...
Screenshot from 2023-02-24 12-56-57

But when I scroll back up, the top part of the sidebar never comes back into view!
Screenshot from 2023-02-24 12-57-06

@sneh721
Copy link
Collaborator

sneh721 commented Mar 3, 2023

I think I have fixed the issue by increasing the min height as suggested. Now the labels are visible even after scrolling.

Before:
image

After:
image

Please let me know if other changes should be made.

@sneh721 sneh721 mentioned this issue Mar 10, 2023
Closed
2 tasks
@misaugstad
Copy link
Member Author

When trying to test this, you should be able to find a set of filters that you can apply that will result in there being only row of images (cards) being shown. This is probably the test case to work with!

@misaugstad misaugstad assigned cyrusnaficy and unassigned nehaa2426 Jul 3, 2024
@cyrusnaficy cyrusnaficy linked a pull request Aug 13, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyrusnaficy cyrusnaficy

Labels
Bug Gallery
Projects
None yet
Milestone
No milestone
6 participants
@jonfroehlich @misaugstad @sneh721 @cyrusnaficy @tanayaxsharma @nehaa2426