Skip to content

Commit

Permalink
Merge pull request #27 from ProjectPenrose/develop
Browse files Browse the repository at this point in the history
Develop
  • Loading branch information
alexsc6955 authored Jan 20, 2024
2 parents 1fa4834 + d34f2b9 commit e396f5d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.4.9] - 2024-01-20
### Changed
- `createElement` function replaced by `document.createElement` in `Paradox.buildElement` function because it was causing issues with elements attributes

## [0.4.8] - 2024-01-18
### Removed
- Types sport from index
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "penrose-paradox",
"version": "0.4.8",
"version": "0.4.9",
"description": "Simple vanilla JavaScript library for beginners",
"keywords": [
"penrose",
Expand Down
4 changes: 2 additions & 2 deletions src/core/buildElement/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ export default function buildElement(
// Destructure and provide default values for the options parameter
const { id = "", classList = "", children = [], attributes = {}, events = {}, text = "", style = {} } = options;

// Create a new HTML element
const element = createElement(tag);
// Create a new HTML element TODO: Review createElement function
const element = document.createElement(tag);

// Set the element ID if provided
if (id) element.id = id.trim();
Expand Down

0 comments on commit e396f5d

Please sign in to comment.