Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing escape character #219

Merged

Conversation

Gautzilla
Copy link
Contributor

Should resolve the syntax warning when using the strptime function.

@Gautzilla Gautzilla added the short term Issue that takes a short time to be corrected label Oct 24, 2024
@Gautzilla Gautzilla requested a review from mathieudpnt October 24, 2024 13:12
@Gautzilla Gautzilla self-assigned this Oct 24, 2024
@Gautzilla
Copy link
Contributor Author

I struggled a tiny bit an awful lot with the handling of warnings in pytest.

At first I wanted to add an assert to the tests that check that no SyntaxWarning is raised anymore, but I couldn't figure out a simple way to do so.

I ended up turning SyntaxWarnings into errors in the pytest scope (by adding a filter to the pyproject.toml file): That way, the tests would just throw an error if a SyntaxWarning is encountered.

This happens project-wide tho, so we'll have to be a bit meticulous on the syntax (I guess that's kind of a good thing 🥸)

@Gautzilla Gautzilla merged commit 242f7a9 into Project-OSmOSE:main Oct 30, 2024
1 check passed
@Gautzilla Gautzilla deleted the hotfix/invalid-escape-sequence branch October 30, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
short term Issue that takes a short time to be corrected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants