Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

71: Only load .env if it exists on setup.sh and exit with error if an… #72

Conversation

lfse-slafleur
Copy link
Member

…y env variables from .env-template are missing.

…y env variables from .env-template are missing.
@lfse-slafleur lfse-slafleur self-assigned this Jul 3, 2024
@lfse-slafleur lfse-slafleur marked this pull request as ready for review July 3, 2024 12:56
Copy link
Contributor

@MarkTNO MarkTNO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful!
One remark only kind of related to this issue: could we change the name from .env-template to .env.template? PyCharm will then pick-up the right formatting.

@lfse-slafleur
Copy link
Member Author

Very useful! One remark only kind of related to this issue: could we change the name from .env-template to .env.template? PyCharm will then pick-up the right formatting.

Good one! Fixed in 3ffe31d

@lfse-slafleur lfse-slafleur merged commit 0fdfa29 into main Jul 5, 2024
1 check passed
@lfse-slafleur lfse-slafleur deleted the 71-allow-for-non-existing-env-file-for-deployments-that-set-environment-variables branch July 5, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for non-existing .env file for deployments that set environment variables
2 participants