Skip to content

Commit

Permalink
18: DurationParameter should have a min, max and specify its duration…
Browse files Browse the repository at this point in the history
… in seconds instead of milliseconds.
  • Loading branch information
lfse-slafleur committed Sep 13, 2024
1 parent 42b293d commit 21835a1
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 15 deletions.
20 changes: 10 additions & 10 deletions python/src/omotes_sdk_protocol/workflow_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 16 additions & 4 deletions python/src/omotes_sdk_protocol/workflow_pb2.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -151,15 +151,27 @@ class DurationParameter(google.protobuf.message.Message):
DESCRIPTOR: google.protobuf.descriptor.Descriptor

DEFAULT_FIELD_NUMBER: builtins.int
default: builtins.int
MINIMUM_FIELD_NUMBER: builtins.int
MAXIMUM_FIELD_NUMBER: builtins.int
default: builtins.float
"""optional uint32 default = 1; Replaced by default = 2"""
minimum: builtins.float
maximum: builtins.float
def __init__(
self,
*,
default: builtins.int | None = ...,
default: builtins.float | None = ...,
minimum: builtins.float | None = ...,
maximum: builtins.float | None = ...,
) -> None: ...
def HasField(self, field_name: typing_extensions.Literal["_default", b"_default", "default", b"default"]) -> builtins.bool: ...
def ClearField(self, field_name: typing_extensions.Literal["_default", b"_default", "default", b"default"]) -> None: ...
def HasField(self, field_name: typing_extensions.Literal["_default", b"_default", "_maximum", b"_maximum", "_minimum", b"_minimum", "default", b"default", "maximum", b"maximum", "minimum", b"minimum"]) -> builtins.bool: ...
def ClearField(self, field_name: typing_extensions.Literal["_default", b"_default", "_maximum", b"_maximum", "_minimum", b"_minimum", "default", b"default", "maximum", b"maximum", "minimum", b"minimum"]) -> None: ...
@typing.overload
def WhichOneof(self, oneof_group: typing_extensions.Literal["_default", b"_default"]) -> typing_extensions.Literal["default"] | None: ...
@typing.overload
def WhichOneof(self, oneof_group: typing_extensions.Literal["_maximum", b"_maximum"]) -> typing_extensions.Literal["maximum"] | None: ...
@typing.overload
def WhichOneof(self, oneof_group: typing_extensions.Literal["_minimum", b"_minimum"]) -> typing_extensions.Literal["minimum"] | None: ...

global___DurationParameter = DurationParameter

Expand Down
5 changes: 4 additions & 1 deletion src/workflow.proto
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ message DateTimeParameter {
}

message DurationParameter {
optional uint32 default = 1;
// optional uint32 default = 1; Replaced by default = 2
optional float default = 2;
optional float minimum = 3;
optional float maximum = 4;
}

message WorkflowParameter {
Expand Down

0 comments on commit 21835a1

Please sign in to comment.