Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ascend custom configuration file settings for NPU virtualization #510

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

wawa0210
Copy link
Member

@wawa0210 wawa0210 commented Sep 23, 2024

What type of PR is this?
/kind bug
/kind feature

The pr introduces #492

The same-level directories of helm charts templates will be identified as sub-charts by helm, causing helm packaging to fail

image

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@wawa0210
Copy link
Member Author

/cc @zoyopei

@wawa0210 wawa0210 added the kind/bug Something isn't working label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 26.99% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@wawa0210 wawa0210 changed the title Fixed Ascend configuration file being placed outside helm charts template Support Ascend custom configuration file settings for NPU virtualization Sep 24, 2024
@wawa0210 wawa0210 added the kind/feature new function label Sep 24, 2024
@zoyopei
Copy link
Contributor

zoyopei commented Sep 24, 2024

/approve

@wawa0210 wawa0210 removed the kind/bug Something isn't working label Sep 24, 2024
@wawa0210 wawa0210 merged commit 02e7a20 into Project-HAMi:master Sep 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature new function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants