Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling experiments. New mode: off #1546

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Disabling experiments. New mode: off #1546

merged 1 commit into from
Jan 29, 2024

Conversation

asanzo
Copy link
Contributor

@asanzo asanzo commented Jan 26, 2024

Fixes #1539

  • Agregué una nueva estrategia y grupo experimental: "off".
  • Eso básicamente apaga la survey y prende siempre el feedback.
  • Agregué los tests correspondientes
  • Lo puse por default en el build local
  • Y también en el CI para producción.

@asanzo asanzo requested a review from a team as a code owner January 26, 2024 19:36
asanzo
asanzo commented Jan 26, 2024
View reviewed changes
tests/unit/services/experiments-test.js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acá hice un pequeño refactor, había un parámetro que podía calcularse, así que lo saqué.

rgonzalezt
rgonzalezt approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@rgonzalezt rgonzalezt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@asanzo asanzo merged commit cd3b238 into develop Jan 29, 2024
4 checks passed
@asanzo asanzo deleted the disableExperiments branch January 29, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgonzalezt rgonzalezt rgonzalezt approved these changes

@danielferro69 danielferro69 Awaiting requested review from danielferro69 danielferro69 is a code owner automatically assigned from Program-AR/pilasbloqueros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

¿Frenar? experimento
2 participants
@asanzo @rgonzalezt