Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes #313

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Hotfixes #313

merged 4 commits into from
Oct 3, 2024

Conversation

dlopezalvas
Copy link
Contributor

@dlopezalvas dlopezalvas commented Oct 2, 2024

Resolves #311

pilas-bloques-ember: Program-AR/pilas-bloques-ember#1556
pilas-bloques-exercises: Program-AR/pilas-bloques-exercises#70

Copy link
Contributor

@rgonzalezt rgonzalezt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dia, funciona todo re bien. Pero tuve que agregar esto en el package.json en la parte de los scripts porque sino no me levantaba.

O sea, en esta branch está así:

"prestart": "rm node_modules/.vite/deps/* && node scripts/setEmberRoot.js public/emberPB ''",

y tuve que dejarlo así como está en develop:

"prestart": " [ -d node_modules/.vite/deps ] && rm node_modules/.vite/deps/*; node scripts/setEmberRoot.js public/emberPB ''",

Sino me tiraba este error:

> [email protected] prestart
> rm node_modules/.vite/deps/* && node scripts/setEmberRoot.js public/emberPB ''

rm: cannot remove 'node_modules/.vite/deps/*': No such file or directory
rgonzalez@i7caf02:~/Desktop/repos/pilasbloques/pilas-bloques-app$ git chec

@dlopezalvas
Copy link
Contributor Author

@rgonzalezt

Ahí lo agregué al PR por si hacemos otro hotfix antes de mergear develop a main👍

@dlopezalvas dlopezalvas merged commit 196580d into main Oct 3, 2024
10 checks passed
@dlopezalvas dlopezalvas deleted the hotfixes branch October 3, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants