Navhorizontal with user avatar #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any thoughts, @malberts ? |
|
can we get this integrated? |
Merged
malberts
reviewed
Jul 29, 2024
| $this->indent() ); | ||
|
|
||
| $this->indent( -1 ); | ||
|
|
||
| return $dropdownToggle; | ||
| } | ||
|
|
||
| private function setUserAvatar() { | ||
| if ( !empty( $GLOBALS['chameleonDisableAvatar'] ) ) { |
There was a problem hiding this comment.
I merged the code, but this is not the right approach:
- This should be a setting/attribute on the component in the XML. It is not a global Chameleon setting, but rather specific to one component.
- It should be opt-in (avatars should be disabled by default), otherwise existing wikis might suddenly see avatars if they coincidentally had images with the matching names. This causes an unexpected change.
malberts
pushed a commit
that referenced
this pull request
Jul 29, 2024
* add user-avatar * add userAvatar * fix comment * add avatar * fix comment * added global parameter chameleonDisableAvatar * restore Fix deprecated Hooks usage --------- Co-authored-by: Bernhard Krabina <[email protected]> (cherry picked from commit ab5b9cc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to display an avatar in
NavbarHorizontal,PersonalTools, as follows:the avatar will be displayed using a file with same username of the user (like Admin.png), or using a dedicated hook
ChameleonNavbarHorizontalPersonalToolsAvatarUrl, that can for instance be used in conjunction with SemanticMediawiki by setting a file as value of the propertyUser image, and then retrieving the thumbnail from a code snippet placed in LocalSettings.php. (or from a dedicated extension)Also the pull request includes the global parameter
$chameleonDisableAvatarto disable the avatar.