[WIP] Port Wrong Path Aware EIP #4
Conversation
| // TODO | ||
| } | ||
| #else | ||
| uint32_t eip::prefetcher_cache_operate(uint64_t addr, uint64_t ip, uint64_t instr_id, uint8_t cache_hit, uint8_t prefetch_hit, uint32_t metadata_in) |
There was a problem hiding this comment.
The function signature is changed NEED to update without breaking other things.
metadata_in is updated to have wrong_path info
|
|
||
| // IMPORTANT: This function needs to be called in the same order as prefetcher_cache_operate, | ||
| // meaning that after calling prefetcher_squash, none of the squashed instructions should call prefetcher_cache_operate. | ||
| // Otherwise, performance may be sub-optimal. |
There was a problem hiding this comment.
Get more clarity on where it has to be called.
With current understanding have called at following line in ooo_cpu.cc
There was a problem hiding this comment.
prefetcher_cache_operate is called in try_hit(..) of cache.cc, I believe the way impl_prefetcher_squash is called should be fine provided on a mispredicated branch we flush the pipeline
|
I don't have any specific reviews of the code, I think the addition of |
Port Wrong-Path-Aware Entangling Instruction Prefetcher
https://github.com/alberto-ros/EntanglingInstructionPrefetcher/blob/main/TC-24/ISCA_Entangling_4Ke_opt.cc