Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language facet filter to document search (#1402) #1650

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

blms
Copy link
Contributor

@blms blms commented Oct 10, 2024

In this PR

Per #1402:

  • Index all languages of translation footnotes (by name) per document
  • Add Select facet filter form field type
  • Use that facet to select languages of translation
  • Disable form control unless "has translation" is checked

@blms blms force-pushed the feature/1402-translation-lang-search branch from ef02743 to da07d3e Compare October 10, 2024 16:35
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.87%. Comparing base (957daf0) to head (5fca8e4).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1650   +/-   ##
========================================
  Coverage    98.87%   98.87%           
========================================
  Files          241      241           
  Lines        14941    14989   +48     
========================================
+ Hits         14773    14821   +48     
  Misses         168      168           

@blms blms merged commit 6916228 into develop Oct 10, 2024
15 checks passed
@blms blms deleted the feature/1402-translation-lang-search branch October 10, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant