Respect annotation reordering in document detail page (#1438)

[blms]

In this PR

Per #1438:

• Add order_by("content__schema:position", "created") to the annotation set in Footnote.content_html, so that reordered annotations will appear in the correct order on the document detail page

Questions

• Since this is a cached property, I'm wondering about cache busting when annotations are reordered. It seems to work for me locally when I hard refresh the doc detail page, but wondering if that's always the case / if there's a way to do it automatically from the backend?

[codecov]

Codecov Report

Merging #1439 (6dc44df) into develop (9dfe138) will increase coverage by 0.01%.
Report is 9 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1439      +/-   ##
===========================================
+ Coverage    98.69%   98.71%   +0.01%     
===========================================
  Files          200      201       +1     
  Lines        11102    11241     +139     
===========================================
+ Hits         10957    11096     +139     
  Misses         145      145              

[rlskoeser]

Update looks good to me, makes sense.

The cached property only applies to the object instance, to avoid recomputing a dynamic property multiple times for generating a page (possibly not strictly needed in this case, unless we have logic that depends on whether there is content). When you reload the page you get a new instance of the object, so this caching isn't relevant. I suspect that's why it worked for you on a reload.

[rlskoeser]

probably worth a one-line comment here documenting what this is for

I checked, default ordering is by created; makes sense we wouldn't want to rely on an optional/custom parameter for sort