Merge branch 'release/4.17.2'

.github/workflows/codeql-analysis.yml

@@ -25,7 +25,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL

.github/workflows/dbdocs.yml

@@ -21,7 +21,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       # Node is required to use dbdocs
       - name: Setup node
         uses: actions/setup-node@v2-beta
@@ -37,7 +37,7 @@ jobs:
       - name: Get Python version
         run: echo "PYTHON_VERSION=$(cat .python-version)" >> $GITHUB_ENV
       - name: Setup Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Install dependencies

.github/workflows/sphinx_docs.yml

@@ -15,14 +15,14 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       # Python version to use is stored in the .python-version file, which is the
       # convention for pyenv: https://github.com/pyenv/pyenv
       - name: Get Python version
         run: echo "PYTHON_VERSION=$(cat .python-version)" >> $GITHUB_ENV
       - name: Setup Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ env.PYTHON_VERSION }}
 

.github/workflows/unit_tests.yml

@@ -35,7 +35,7 @@ jobs:
           - 8983:8983
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       # use docker cp to copy the configset, then bash to set ownership to solr
       - name: Copy Solr configset to solr service
@@ -51,7 +51,7 @@ jobs:
       - name: Get Python version
         run: echo "PYTHON_VERSION=$(cat .python-version)" >> $GITHUB_ENV
       - name: Setup Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ env.PYTHON_VERSION }}
 

.github/workflows/visual_tests.yml

@@ -23,7 +23,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout commits up to and including HEAD^2
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 2
 
@@ -58,7 +58,7 @@ jobs:
           - 8983:8983
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Decrypt encrypted fonts zip
         run: |
@@ -89,7 +89,7 @@ jobs:
         run: echo "PYTHON_VERSION=$(cat .python-version)" >> $GITHUB_ENV
 
       - name: Setup Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ env.PYTHON_VERSION }}
 

.python-version

@@ -1 +1 @@
-3.9.13
+3.9.19

CHANGELOG.rst

@@ -1,6 +1,11 @@
 Change Log
 ==========
 
+4.17.2
+------
+
+- bugfix: Unable to rotate or reorder images in admin due to undefined rotation controls
+
 4.17.1
 ------
 

geniza/__init__.py

@@ -1,4 +1,4 @@
-__version_info__ = (4, 17, 1, None)
+__version_info__ = (4, 17, 2, None)
 
 
 # Dot-connect all but the last. Last is dash-connected if not None.

sitemedia/js/admin.js

@@ -276,10 +276,10 @@ function appendRotationControls() {
             "div.field-admin_thumbnails div.admin-thumbnail"
         ) || [];
     orderImages.forEach((div, i) => {
-        rotationControls = document.createElement("div");
+        const rotationControls = document.createElement("div");
         rotationControls.classList.add("rotation-controls");
         // rotate left button
-        rotateLeftButton = document.createElement("button");
+        const rotateLeftButton = document.createElement("button");
         rotateLeftButton.classList.add("rotate-left");
         rotateLeftButton.setAttribute("type", "button");
         rotateLeftButton.setAttribute(
@@ -289,7 +289,7 @@ function appendRotationControls() {
         rotateLeftButton.innerHTML = "↺";
         rotationControls.appendChild(rotateLeftButton);
         // rotate right button
-        rotateRightButton = document.createElement("button");
+        const rotateRightButton = document.createElement("button");
         rotateRightButton.classList.add("rotate-right");
         rotateRightButton.setAttribute("type", "button");
         rotateRightButton.setAttribute(