Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

160-XXXX Errors #8

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Conversation

Spletz47
Copy link

@Spletz47 Spletz47 commented Aug 7, 2024

Resolves #XXX

Changes:

Adds additional 160 error codes and provides messages and descriptions that were missing from existing ones.

Copy link
Member

@jonbarrow jonbarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the late review. I've been extremely busy

"0105": {
"name": "Unknown",
"message": "There is a problem with the USB storage device.\n\nPlease contact the manufacturer of the device.\nCheck the device documentation for contact details.",
"short_description": "USB device error",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a short description is being added, then a long one should also be added. The short fields are designed for use by the Discord bot. The long fields are used for the website. Only having one of them makes the data unavailable by the other.

You can see a good example of how to format these fields here https://github.com/PretendoNetwork/error-codes/blob/master/data/104/2210/en_US.json

This goes for all cases of this, as there are multiple in this PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed up now
Speaking of 104-2210, I've completed that one too. Also, for some reason it doesn't appear on Bandwidth when asking in the Discord server. Hasn't for a while. Just worth bringing it up now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bandwidth won't show any new error codes until a new release of this repo is made and Bandwidth is updated to use it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding me, the existing one must not have that error documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants