Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

104-XXXX Errors #7

Closed
wants to merge 14 commits into from
Closed

Conversation

Spletz47
Copy link

@Spletz47 Spletz47 commented Aug 1, 2024

Changes:

PR that will be worked on over time, adding names, messages and causes/solutions for 104 error codes.

@jonbarrow
Copy link
Member

jonbarrow commented Aug 2, 2024

There's a few issues with this PR as-is

  1. Please in the future make issues to be approved before making PRs, issues such as this [Enhancement]: Cause to 022-2402 #6
  2. The git history here looks really scuffed. There's commits from Additional Error Codes, Messages, Descriptions and Solutions #5 also here
  3. You are, again, targetting the master branch. As stated in your other PR (and in the contribution guide), you must target the dev branch in repositories
  4. Commit messages should be in lowercase unless referencing something that must be uppercase (such as a function whose name has uppercase letters, or person). This includes scopes. For instance Fix: Adjusted descriptions as per Jon's suggestions should be fix: adjusted descriptions as per Jon's suggestions

You will likely need to redo this PR entirely to fix the git history

@Spletz47 Spletz47 closed this Aug 7, 2024
@Spletz47 Spletz47 deleted the 104-Errors branch August 7, 2024 02:04
@Spletz47 Spletz47 restored the 104-Errors branch August 7, 2024 04:04
@Spletz47 Spletz47 deleted the 104-Errors branch August 7, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants