Remove the “>” selector to make the selector more flexible #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hlavtox
approved these changes
Oct 24, 2024
jf-viguier
approved these changes
Oct 24, 2024
|
ping @PrestaShop/prestashop-core-developers could this be QA tested by a dev ? |
florine2623
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Hello @LaBisquerie ,
Tested the PR and classic features of this module.
- Configuration of Customer notifications (logged-in and guest customers)
- Configuration Merchant notifications (New order, Our of stock, Return)
No change noticed on usual behavior nor exception displayed.
It is QA ✅ !
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing this selector, we can add HTML elements between them and maintain the current functionality.