-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core weekly 7 of 2020 #647
Conversation
|
||
Dear developers, | ||
|
||
Last week our Product Team had a wonderful surprise: they received a notification telling them someone opened a [Pull Request on the Specifications repository](https://github.com/PrestaShop/prestashop-specs/pull/86) ! They were delighted to see the community willing to collaborate on us on this project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sam-pires @colinegin Please tell me if you agree with this 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments @matks :
- i'm not sure people are aware of this repo, so maybe we should give a few info about it
- i'm not sure we should call it a "project"
- maybe we could directly thank the contributor whose name is arouiadib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, can you write what you'd like to say 😉 ?
I dont want to write something, then you provide feedback, then I write something, then you provide feedback ... 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My proposition : "Last week our Product Team had a wonderful surprise: they received a notification telling them someone opened a Pull Request on the Specifications repository ! This is the first community contribution since this repo dedicated to centralize all core and module functional specifications has been created. They were delighted to see the community willing to collaborate with us on this huge work."
Wdyt @matks @sam-pires ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ❤️ it and included it here 😉 https://github.com/PrestaShop/prestashop.github.io/pull/647/files#diff-1e48a63d130a67f0c0cbb5a09ea0c18aR21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I'll quickly clean the repo tree we messed up with Gitbook, and add some guidelines on how to contribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you wait a bit before merging? 🙂 like a couple of hours
Co-Authored-By: Pablo Borowicz <[email protected]>
…ub.io into core-weekly-7-2020
Thanks for review |
No description provided.