Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue-567 #632

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix: issue-567 #632

merged 1 commit into from
Jun 27, 2024

Conversation

tblivet
Copy link
Contributor

@tblivet tblivet commented May 22, 2024

Questions Answers
Description? Fix #567
Type? bug fix / improvement
BC breaks? no
Deprecations?
Fixed ticket? Fix #567
Sponsor company @PrestaShopCorp
How to test? You can follow the steps described in the issue
  • I have hidden the zoom icon on the quick view as this functionality was not present in the classic theme. Due to the conception of Hummingbird, it seems complicated to implement it.
  • On the product page, an improvement has been made to the zoom functionality because the section that handles the images was not being updated on combination change.

Before :

before.mov

After :

after.mov

Copy link
Collaborator

@ga-devfront ga-devfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@tblivet tblivet changed the title Fix: issue-576 Fix: issue-567 May 22, 2024
@florine2623 florine2623 self-assigned this Jun 5, 2024
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tblivet ,

The zoom icon on quick view is not hidden. When I click on it, the page is greyed out :

Screen.Recording.2024-06-05.at.11.46.12.mov

Could you check it please ?

The improvement works as expected ✅

Thanks!

@florine2623 florine2623 removed their assignment Jun 5, 2024
@tblivet
Copy link
Contributor Author

tblivet commented Jun 5, 2024

Hello @florine2623,

I have just re-tested, and I don't have any problems.
Maybe it's a cache issue? Have you disabled and cleared the cache from the BO "Advanced Parameters -> Performance" section?
Or tried compiling hummingbird assets with npm run build?

@florine2623 florine2623 self-assigned this Jun 27, 2024
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tblivet !

I retested this feature. it works as expected. The right images are displayed according to the combinations. I tested on product details page and quickview page. ✅

But I have noticed another bug that can be fixed in another PR. I do not have the carousel of images displayed.
It should be displayed at the bottom the the main image in product page and quickview.
It should be displayed on the right side when zoomed in.

Screen.Recording.2024-06-27.at.13.13.30.mov

@nicosomb nicosomb merged commit 3f34ea9 into PrestaShop:develop Jun 27, 2024
6 checks passed
@nicosomb nicosomb added this to the v0.2.1 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

In quick view, magnifying glass on product doesn't work, the modal is directly closed.
7 participants