-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minimal quantity reset #145
base: develop
Are you sure you want to change the base?
Conversation
ComonSoft
commented
May 28, 2024
•
edited
Loading
edited
Questions | Answers |
---|---|
Description | Fixes an issue when a product has a minimum quantity by sale, and user enter a value greater than the minimal with 2 or 3 digits in input field, and click outside, the value comes back to minimal |
Category | FO |
Type | bug fix |
BC breaks | no |
Deprecations | no |
Fixed ticket | Fixes #36245, Fixes #28531 |
Sponsor company | @ComonSoft |
How to test | 1. Go to back office, create a product with a minimal quantity for sale by 5 (sample, works with any value) less than 10 |
2. Go to frontend product page | |
3. In the quantity field, enter quantity greater than 10 by keyboard | |
4. Click outside the input (any where except +- arrows) | |
5. The quantity in the field goes back to 5. |
Fixed minimum quantity reset
Hello @ComonSoft, Some checks were not successful. Can you check that? Thanks! |
Added missing radix to parseint function
Done |
Hi @ComonSoft! |
ESLint compliant
Done |
Remove trailing space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ComonSoft ,
I have the same behavior with and without your PR using PS 8.1.x and PS 9.0x with classic theme.
In both cases, there's no reset of the minimal quantity when I click outside of the quantity input.
Screen.Recording.2024-06-26.at.15.39.01.mov
I think this PR can be closed.
@PrestaShop/product-council what do you think ?
Sorry, but the bug is present set the minimal quantity to a value inferior to 10 ;-) |