Backport PR #140 (Fix: The new password policy is not present in the reset password) #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matthieu-rolland
commented
Apr 8, 2024
matthieu-rolland
commented
| Questions | Answers |
|---|---|
| Description? | Backport PR #140 |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| Sponsor company | PrestaShop SA |
| How to test? | see PR PR #140 |
jolelievre
approved these changes
Apr 8, 2024
boherm
approved these changes
Apr 8, 2024
florine2623
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Hello @matthieu-rolland ,
Works as expected, the password policy is working well.
Impossible to set a weak password.
Impossible to set a password that does not match the policy.
LGTM ✅
Thanks!
florine2623
added
QA ✔️
|
thank you @florine2623 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.