Feat: connect new UI #879
Feat: connect new UI #879
Conversation
ga-devfront
added
new feature
waiting for dev
Blocked
ga-devfront
force-pushed
the
feat/connect-new-ui
branch
from
8305e61 to
d2b2cd9
Compare
ga-devfront
removed
Blocked
| /** @var Twig_Environment */ | ||
| protected $twig; | ||
|
|
||
| public function __construct(UpgradeContainer $upgradeContainer) | ||
| { | ||
| $this->upgradeContainer = $upgradeContainer; | ||
| $this->twig = $this->upgradeContainer->getTwig(); |
There was a problem hiding this comment.
For me there is a topic on twig typing here. $this->upgradeContainer->getTwig() can given Twig_Environment or Twig/Environment
|
|
||
| class AbstractPageController extends AbstractGlobalController | ||
| { | ||
| public function psVersionClass(): string |
There was a problem hiding this comment.
| public function psVersionClass(): string | |
| private function getPsVersionClass(): string |
There was a problem hiding this comment.
Hi @ga-devfront
Thank you for your PR, I tested it and it seems to works as you can see :
Tested from :
1.7.8.9 to 8.1.7
8.0.5 to 8.1.7
8.1.5 to 8.1.7
8.1.7 to 9.0.0
8.1.5 to 9.0.0
8.0.5 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
|
@ga-devfront This PR has been reviewed by the QA team, so please check the comments from @M0rgan01 and create the requested changes in another PR. You may merge this one. |
|
No really a security issue ^^ |
&new-ui=1&route=welcomeat the end of the URL.